test: swap arguments in strictEqual() for parallel/test-buffer-copy #23204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeltaEvo
changed the title
targos
reviewed
Oct 1, 2018
test/parallel/test-buffer-copy.js
Outdated
| @@ -23,7 +23,7 @@ let cntr = 0; | |||
| b.fill(++cntr); | |||
| c.fill(++cntr); | |||
| const copied = c.copy(b, 0, 0); | |||
| assert.strictEqual(c.length, copied); | |||
| assert.strictEqual(copied, c.length); | |||
| for (let i = 0; i < c.length; i++) { | |||
| assert.strictEqual(c[i], b[i]); | |||
There was a problem hiding this comment.
I think these should be swapped as well (we copied c into b, so c holds the expected values?)
test/parallel/test-buffer-copy.js
Outdated
| @@ -34,7 +34,7 @@ let cntr = 0; | |||
| b.fill(++cntr); | |||
| c.fill(++cntr); | |||
| const copied = c.copy(b, 0); | |||
| assert.strictEqual(c.length, copied); | |||
| assert.strictEqual(copied, c.length); | |||
| for (let i = 0; i < c.length; i++) { | |||
| assert.strictEqual(c[i], b[i]); | |||
cjihrig
approved these changes
Oct 1, 2018
targos
added
the
author ready
lpinca
approved these changes
Oct 2, 2018
benjamingr
approved these changes
Oct 2, 2018
jasnell
approved these changes
Oct 2, 2018
targos
pushed a commit
to targos/node
that referenced
this pull request
Oct 6, 2018
Swap arguments in strictEqual() for parallel/test-buffer-copy. PR-URL: nodejs#23204 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 6, 2018
Swap arguments in strictEqual() for parallel/test-buffer-copy. PR-URL: #23204 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Oct 7, 2018
Swap arguments in strictEqual() for parallel/test-buffer-copy. PR-URL: #23204 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Oct 10, 2018
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2018
Swap arguments in strictEqual() for parallel/test-buffer-copy. PR-URL: #23204 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes